Skip to content

Commit

Permalink
Merge pull request #8850 from element-hq/fix/jme/8894-ea-intercepts-m…
Browse files Browse the repository at this point in the history
…as-urls

Replace `*.element.io` deep link with actual hosts
  • Loading branch information
bmarty authored Jun 25, 2024
2 parents 4d27c84 + 0292749 commit b5758c5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/8894.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Intercept only links from `element.io` well known hosts. The previous behaviour broke OIDC login in Element X.
8 changes: 7 additions & 1 deletion vector/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,13 @@
<category android:name="android.intent.category.BROWSABLE" />

<data android:scheme="https" />
<data android:host="*.element.io" />
<!-- Note: we can't use "*.element.io" here because it'll intercept the "mas.element.io" domain too. -->
<!-- Matching asset file: https://app.element.io/.well-known/assetlinks.json -->
<data android:host="app.element.io" />
<!-- Matching asset file: https://develop.element.io/.well-known/assetlinks.json -->
<data android:host="develop.element.io" />
<!-- Matching asset file: https://staging.element.io/.well-known/assetlinks.json -->
<data android:host="staging.element.io" />
</intent-filter>
</activity>

Expand Down

0 comments on commit b5758c5

Please sign in to comment.