Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleMenuItem requires both onChange and onSelect #288

Open
robintown opened this issue Dec 13, 2023 · 1 comment
Open

ToggleMenuItem requires both onChange and onSelect #288

robintown opened this issue Dec 13, 2023 · 1 comment
Labels
P-Web Platform Web T-Defect

Comments

@robintown
Copy link
Member

robintown commented Dec 13, 2023 •
edited
Loading

Platform

Web

Package version

  • v0.9.4

Description

If you don't provide onChange to ToggleMenuItem, then you get this warning:
image(1)

And if you don't provide onSelect, then you get this error:
image(2)

Semantically, these props are redundant to each other, and we should unify them. It's not at all clear which functions the two callbacks are meant to serve.
@robintown robintown added P-Web Platform Web T-Defect labels Dec 13, 2023
@MidhunSureshR
Copy link
Member

Fixed by element-hq/compound-web#229?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-Web Platform Web T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MidhunSureshR @robintown