Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script tags are reformatted which breaks CSP sha hashes #1007

Open
regular opened this issue Nov 3, 2023 · 0 comments
Open

script tags are reformatted which breaks CSP sha hashes #1007

regular opened this issue Nov 3, 2023 · 0 comments
Labels
bug Something isn't working needs verification Bug needs to be verified with reproduction

Comments

@regular
Copy link

regular commented Nov 3, 2023

Hi! Thanks for this amazing tool! I really enjoy the over-engineeredness of this! (scraping Apple docs)

Here is my problem:

The index.html file I want pwa-asset-generator to modify was created by piping minified browserify output through indexhtmlify and metadataify and my tools add a CSP http-equiv tag containing the sha256 of the inlined Javascript. This all works fine, except that pwa-asset-generator not only modifies the but also pretty-prints the <script> tag, which not only increases the file size, but more importantly, breaks the sha.

I file this as a bug, because I think that changes occurring outside of should not occur.

Thanks for sharing!

@regular regular added bug Something isn't working needs verification Bug needs to be verified with reproduction labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs verification Bug needs to be verified with reproduction
Projects
None yet
Development

No branches or pull requests

1 participant