fix: electron-builder fails when list of node_modules files is too big to pass in a glob

[beyondkmp]

fix #8705

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2f8401e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[beyondkmp]

The main issue in this MR is caused by users directly configuring the entire node_modules in the asarUnpack pattern.

asarUnpack supports '!', but electron/asar doesn't support this '!'. This problem will occur whenever users have directories containing a large number of files.

My thought is whether electron-builder's asarUnpack should also not support '!' patterns, keeping consistent with electron/asar. @mmaietta Do you have any good ideas or suggestions?

[mmaietta]

Is there a way we can resolve ! filters before passing to electron/asar's minimatch?

It seems like a pretty hefty decrease in electron-builder functionality if we remove the ! filter feature?