You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
%localAppData%/{updaterCacheDirName} - windows
{homeDir}/Library/Caches/{updaterCacheDirName} - mac
{homeDir}/.cache/{updaterCacheDirName} - linux
I would like to change the download location to include orgName folder:
%localAppData%/{orgName}/{updaterCacheDirName} - windows
{homeDir}/Library/Caches/{orgName}/{updaterCacheDirName} - mac
{homeDir}/.cache/{orgName}/{updaterCacheDirName} - linux
however, there is no way to currently do that.
Things i considered:
updaterCacheDirName - it's formed from the sanitized app name + -updater. So there is no way to change it to {orgName}/{appName}, since any slashes will be removed when sanitizing the app name..
baseCacheDir is in AppAdapter class. I can pass a custom AppAdapter when initializing AppUpdater, but then httpExecutor is set to null:
if (app == null) {
this.app = new ElectronAppAdapter()
this.httpExecutor = new ElectronHttpExecutor((authInfo, callback) => this.emit("login", authInfo, callback))
} else {
this.app = app
this.httpExecutor = null as any
}
I assume thats because the custom AppAdapter is mostly used for tests? AppAdapter doesnt seem to be documented, so I cannot tell if it's something I should be using or not.
I would be willing to make a PR to allow customizing the cache dir, either by: updating the AppUpdater constructor to not set httpExecutor to null, or by adding the baseCacheDir to AllPublishOptions. Let me know if that's something you would consider & which option you would prefer.
Note: I saw this issue for the same feature request, but it's been closed for a while now. I can close this one if you guys want to reopen that one instead.
The text was updated successfully, but these errors were encountered:
Currently, the following locations are used:
I would like to change the download location to include
orgName
folder:however, there is no way to currently do that.
Things i considered:
updaterCacheDirName
- it's formed from the sanitized app name +-updater
. So there is no way to change it to{orgName}/{appName}
, since any slashes will be removed when sanitizing the app name..baseCacheDir
is inAppAdapter
class. I can pass a customAppAdapter
when initializingAppUpdater
, but thenhttpExecutor
is set tonull
:I assume thats because the custom
AppAdapter
is mostly used for tests?AppAdapter
doesnt seem to be documented, so I cannot tell if it's something I should be using or not.I would be willing to make a PR to allow customizing the cache dir, either by: updating the
AppUpdater
constructor to not sethttpExecutor
to null, or by adding thebaseCacheDir
toAllPublishOptions
. Let me know if that's something you would consider & which option you would prefer.Note: I saw this issue for the same feature request, but it's been closed for a while now. I can close this one if you guys want to reopen that one instead.
The text was updated successfully, but these errors were encountered: