Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Errors not handled in Box of Errors for Function Results #5

Open
sachindkagrawal15 opened this issue Feb 21, 2024 · 0 comments

Comments

@sachindkagrawal15
Copy link
Collaborator

When we use Box on function returning a result, the underlying error type is only known at runtime and not statically known.

There are instances in code where Box is used but there is no handling of dynamic errors in the function

Examples:

  1. zk_prover/src/merkle_sum_tree/tree.js
    Function get_leaf_node_hash_preimage
  2. zk_prover/src/merkle_sum_tree/utils/build_tree.rs
    Function build_merkle_tree_from_leaves
  3. zk_prover/src/merkle_sum_tree/mst.rs
    Function from_params
  4. backend/src/apis/round.rs
    Function new
@sachindkagrawal15 sachindkagrawal15 changed the title Dynamic Errors not handled in Box of Errors for Function return Dynamic Errors not handled in Box of Errors for Function Results Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant