Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: make sure plugin logger sets context #13201

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Refactor: make sure plugin logger sets context #13201

wants to merge 12 commits into from

Commits on Sep 2, 2021

  1. Refactor: do not generate singleton_class for Loggable 

    what was meant was likely to do a `self.class.logger` here
    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    051c423 View commit details
    Browse the repository at this point in the history

  2. simplify logging Ruby facade impl + fix trace?

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    083513e View commit details
    Browse the repository at this point in the history

  3. Refactor: use asString (CharSequence) where possible 

    also changes the contract from msg.to_str to msg.to_s
    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    761678d View commit details
    Browse the repository at this point in the history

  4. align msg.to_s logging convention change

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d2d9588 View commit details
    Browse the repository at this point in the history

  5. Refactor: prepare for plugin.logger customization 

    also improves performance of plugin.logger invocations
    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    8be02d8 View commit details
    Browse the repository at this point in the history

  6. javadoc for logger methods + prepare for sub-classing

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    b1916aa View commit details
    Browse the repository at this point in the history

  7. Feat: a custom logger per plugin instance

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    b49c46d View commit details
    Browse the repository at this point in the history

  8. Test: adjust spec to consider PluginLogger

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    1e35201 View commit details
    Browse the repository at this point in the history

  9. Chore: keep a todo for plugin.class.logger method

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    8d2c4e1 View commit details
    Browse the repository at this point in the history

  10. only set plugin.id if isn't already set 

    ... for restore to keep the previously set id
    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d9ec497 View commit details
    Browse the repository at this point in the history

  11. Fix: wrong condition (boolean) return

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    2687121 View commit details
    Browse the repository at this point in the history

  12. a quick plugin.logger (context restoration) test

    @kares
    kares committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    11ac7f9 View commit details
    Browse the repository at this point in the history