Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] It should be possible to clear the user-specific system prompt #202279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sorenlouv
Copy link
Member

I noticed that I was not able to clear the user-specific system prompt. I had initially entered "Please speak in Swedish" and saved. Afterwards I wanted to clear this but the save button is disabled if the text content is empty.

image

@sorenlouv sorenlouv requested a review from a team as a code owner November 29, 2024 11:32
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Nov 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv added v7.17.0 release_note:fix backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 29, 2024
@@ -118,7 +117,6 @@ export function KnowledgeBaseEditUserInstructionFlyout({ onClose }: { onClose: (
fill
isLoading={isSaving}
onClick={handleSubmit}
isDisabled={isSubmitDisabled}
Copy link
Contributor

@viduni94 viduni94 Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sorenlouv
I'm unable to clear the user-specific system prompt.
It gives an error..
I'm not sure whether I'm missing something..

Error: Failed to validate: 
  in /body/text: "" does not match expected type NonEmptyString
    at Object.onError (http://localhost:5601/xat/XXXXXXXXXXXX/bundles/plugin/observabilityAiAssistantManagement/1.0.0/observabilityAiAssistantManagement.chunk.0.js:24903:23)
    at Mutation.execute (http://localhost:5601/xat/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:196451:123)
    at async handleSubmit (http://localhost:5601/xat/XXXXXXXXXXXX/bundles/plugin/observabilityAiAssistantManagement/1.0.0/observabilityAiAssistantManagement.chunk.0.js:26014:5)
Screen.Recording.2024-11-29.at.8.11.37.AM.mov

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 1, 2024

💔 Build Failed

  • Buildkite Build
  • Commit: 7947ad2
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202279-7947ad228e72

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / Observability AI Assistant API tests knowledge_base/knowledge_base_user_instructions.spec.ts Knowledge base user instructions Instructions can be saved and cleared again can clear the instruction
  • [job] [logs] FTR Configs #1 / Observability AI Assistant API tests knowledge_base/knowledge_base_user_instructions.spec.ts Knowledge base user instructions Instructions can be saved and cleared again can clear the instruction

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAiAssistantManagement 97.7KB 97.7KB -29.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:fix Team:Obs AI Assistant Observability AI Assistant v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants