[visualizations] lazy load actions #207147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
@elasticmachine merge upstream |
|
There are no new commits on the base branch. |
|
/ci |
1 similar comment
|
/ci |
|
/ci |
nreese
added
Team:Presentation
nreese
added
project:embeddableRebuild
backport:version
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
jbudz
approved these changes
Jan 21, 2025
|
@elasticmachine merge upstream |
markov00
approved these changes
Jan 23, 2025
Comment on lines
21
to
29
| uiActions.addTriggerActionAsync(CONTEXT_MENU_TRIGGER, ACTION_EDIT_IN_LENS, async () => { | ||
| const { EditInLensAction } = await import('./actions_module'); | ||
| return new EditInLensAction(data.query.timefilter.timefilter); | ||
| }); | ||
|
|
||
| uiActions.addTriggerActionAsync(ADD_PANEL_TRIGGER, ADD_AGG_VIS_ACTION_ID, async () => { | ||
| const { AddAggVisualizationPanelAction } = await import('./actions_module'); | ||
| return new AddAggVisualizationPanelAction(types); | ||
| }); |
There was a problem hiding this comment.
Instead of importing the actions_modules isn't better to directly import the Action directly from its file?
Since we are async loading these to reduce a bit the initial loading we can probably also gain a bit during the action loading if we async load the Actions independently, WDYT?
There was a problem hiding this comment.
that makes sense since the actions are for different triggers. Resolved with 4bcd8f0
| @@ -18,7 +18,7 @@ export type HasVisualizeConfig = HasType<'visualization'> & { | |||
| export const apiHasVisualizeConfig = (api: unknown): api is HasVisualizeConfig => { | |||
| return Boolean( | |||
| api && | |||
| apiIsOfType(api, 'visualization') && | |||
| (api as HasType)?.type === 'visualization' && | |||
There was a problem hiding this comment.
avoid using apiIsOfType to avoid importing presentation-publishing package into page load. Since apiIsOfType is so simple, no reason to use the utility method and import such a huge bundle just for it.
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 23, 2025
Clean up visualizations page load size by * lazy loading actions * avoid exporting from index files to avoid exporting unused code * move `urlFor` and `getFullPath` into `url_utils` to avoid including `utils/saved_visualize_utils` in page load bundle --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit d7f801a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 23, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[visualizations] lazy load actions (#207147)](#207147) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-23T18:33:23Z","message":"[visualizations] lazy load actions (#207147)\n\nClean up visualizations page load size by\r\n* lazy loading actions\r\n* avoid exporting from index files to avoid exporting unused code\r\n* move `urlFor` and `getFullPath` into `url_utils` to avoid including\r\n`utils/saved_visualize_utils` in page load bundle\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d7f801ab3e9c22cc77c0fc3da9492008a5a5252a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[visualizations] lazy load actions","number":207147,"url":"https://github.com/elastic/kibana/pull/207147","mergeCommit":{"message":"[visualizations] lazy load actions (#207147)\n\nClean up visualizations page load size by\r\n* lazy loading actions\r\n* avoid exporting from index files to avoid exporting unused code\r\n* move `urlFor` and `getFullPath` into `url_utils` to avoid including\r\n`utils/saved_visualize_utils` in page load bundle\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d7f801ab3e9c22cc77c0fc3da9492008a5a5252a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207147","number":207147,"mergeCommit":{"message":"[visualizations] lazy load actions (#207147)\n\nClean up visualizations page load size by\r\n* lazy loading actions\r\n* avoid exporting from index files to avoid exporting unused code\r\n* move `urlFor` and `getFullPath` into `url_utils` to avoid including\r\n`utils/saved_visualize_utils` in page load bundle\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d7f801ab3e9c22cc77c0fc3da9492008a5a5252a"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jan 23, 2025
Clean up visualizations page load size by * lazy loading actions * avoid exporting from index files to avoid exporting unused code * move `urlFor` and `getFullPath` into `url_utils` to avoid including `utils/saved_visualize_utils` in page load bundle --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Jan 27, 2025
Clean up visualizations page load size by * lazy loading actions * avoid exporting from index files to avoid exporting unused code * move `urlFor` and `getFullPath` into `url_utils` to avoid including `utils/saved_visualize_utils` in page load bundle --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up visualizations page load size by
urlForandgetFullPathintourl_utilsto avoid includingutils/saved_visualize_utilsin page load bundle