Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context.TODO and loggers #3087

Open
michel-laterman opened this issue Nov 7, 2023 · 0 comments · May be fixed by #4168
Open

context.TODO and loggers #3087

michel-laterman opened this issue Nov 7, 2023 · 0 comments · May be fixed by #4168
Assignees
Labels
good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt

Comments

@michel-laterman
Copy link
Contributor

#3078 changed how we pass loggers to mainly use the context.
as part of the change we added context.TODO() where contexts are not available.

We should see if we can replace these calls by altering the function calls.
We can also investigate and decide if we want to explicitly pass the logger object in a few places (such as in the api module).

This could be a good issue for on-week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants