ES|QL: fix lookup-join csv tests with nondeterministic order #118008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
approved these changes
Dec 4, 2024
alex-spies
approved these changes
Dec 4, 2024
alex-spies
reviewed
Dec 4, 2024
Comment on lines
-242
to
-255
| - class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT | ||
| method: test {lookup-join.LookupIPFromIndexKeep ASYNC} | ||
| issue: https://github.com/elastic/elasticsearch/issues/117974 | ||
| - class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT | ||
| method: test {lookup-join.LookupMessageFromIndex ASYNC} | ||
| issue: https://github.com/elastic/elasticsearch/issues/117975 | ||
| - class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT | ||
| method: test {lookup-join.LookupMessageFromIndexKeep ASYNC} | ||
| issue: https://github.com/elastic/elasticsearch/issues/117976 | ||
| - class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT | ||
| method: test {lookup-join.LookupMessageFromIndex SYNC} | ||
| issue: https://github.com/elastic/elasticsearch/issues/117980 | ||
| - class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT | ||
| issue: https://github.com/elastic/elasticsearch/issues/117981 |
There was a problem hiding this comment.
Just a note that this PR fixes all of these CI failures, not just #117981 .
craigtaverner
added
v8.18.0
auto-backport
luigidellaquila
added
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #117974
Fixes: #117975
Fixes: #117976
Fixes: #117980
Fixes: #117981
Tests failing because the order of the results is not deterministic.