Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes considered for 9.0 #2973

Open
1 of 11 tasks
pquentin opened this issue Oct 1, 2024 · 2 comments
Open
1 of 11 tasks

Breaking changes considered for 9.0 #2973

pquentin opened this issue Oct 1, 2024 · 2 comments
Labels
specification tracking Tracking in DevTools roadmap

Comments

@pquentin
Copy link
Member

pquentin commented Oct 1, 2024

When fixing issues with the specification, the most correct option is often a breaking change, and we have to implement workarounds instead, such as reusing existing classes with optional fields. We may want to clean some of this for Elasticsearch 9.0, as it will result in a cleaner, more future proof and more usable specification.

This issue is here to help us track such changes, so that we make them in time for 9.0 and include them in our changelogs.

We also need to consider Elasticsearch breaking changes in the "Done - Accepted". As of 2024-10-01, those breaking changes affect the API:

Do we need to look at the >breaking label in the Elasticsearch repository? https://github.com/elastic/elasticsearch/pulls?q=is%3Apr+label%3A%3Ebreaking+label%3Av9.0.0+sort%3Acreated-asc There will be some overlap with the above.

@pquentin pquentin added the tracking Tracking in DevTools roadmap label Nov 5, 2024
@javanna
Copy link
Member

javanna commented Nov 18, 2024

Hey, I see this issue links the removal of force_source highlighting parameter. Does that require any adjustments in practice?

@pquentin
Copy link
Member Author

Hey Luca, yes it needs to be removed here:

/**
* @deprecated 8.8.0
*/
force_source?: boolean
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification tracking Tracking in DevTools roadmap
Projects
None yet
Development

No branches or pull requests

2 participants