Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render slot for gap area in Metric #2182

Closed
gvnmagni opened this issue Sep 28, 2023 · 0 comments · Fixed by #2303
Closed

Add render slot for gap area in Metric #2182

gvnmagni opened this issue Sep 28, 2023 · 0 comments · Fixed by #2303
Assignees
Labels
enhancement New feature or request :metric Related to Metric chart

Comments

@gvnmagni
Copy link

gvnmagni commented Sep 28, 2023

Is your feature request related to a problem? Please describe.
Solutions teams have requested a way to consistently place tags below the title on the Metric component. This is not easy to force externally with consistency.

image

Describe the solution you'd like
Ideally we allow a render prop on the Metric chart that we pass each datum to in order to render the contents into the gap area.

image

The user would be responsible for padding and sizing of the gap content as applicable to their use case.

Describe alternatives you've considered
Rendering custom elements absolutely relative to the Metric chart. Causes inconsistent placement of contents.

Additional context
Since the Metric uses dom elements this approach is preferred over dimensional placement of the render contents.

@gvnmagni gvnmagni added enhancement New feature or request needs design A design pass is required and not available labels Sep 28, 2023
@nickofthyme nickofthyme self-assigned this Dec 1, 2023
@nickofthyme nickofthyme added :metric Related to Metric chart and removed needs design A design pass is required and not available labels Dec 1, 2023
@nickofthyme nickofthyme changed the title Metric Vis - Add badges Add render slot for gap area in Metric Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :metric Related to Metric chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants