Skip to content

Commit

Permalink
Removed redundant dependencies between stages in .github\workflows\te…
Browse files Browse the repository at this point in the history
…st.yml
  • Loading branch information
SergeyKleyman committed Jun 29, 2023
1 parent f95cf47 commit 9a30716
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
- name: phpt-unit-tests
run: make -f .ci/Makefile run-phpt-tests

test:
static-checks-unit-tests:
name: static-checks-unit-tests
runs-on: ubuntu-latest
timeout-minutes: 30
Expand Down Expand Up @@ -122,8 +122,6 @@ jobs:
runs-on: ubuntu-latest
needs:
- build
- test

This comment has been minimized.

Copy link
@intuibase

intuibase Jun 29, 2023

Contributor

IMO tests are required to trigger build of packages in other case we will build a package with an agent that does not pass the tests

This comment has been minimized.

Copy link
@SergeyKleyman

SergeyKleyman Jun 30, 2023

Author Contributor

You are right - I brought back the dependencies since it's not the purpose of this PR.

- phpt-tests
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
Expand Down Expand Up @@ -159,7 +157,6 @@ jobs:
needs:
- build-packages
- generate-test-packages-matrix
- test
runs-on: ubuntu-latest
strategy:
max-parallel: 20
Expand Down

0 comments on commit 9a30716

Please sign in to comment.