-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 6 support #108
Comments
@ipodishima Hi. I am planning to bring swift6 support shortly. But I dont see issues with RouteComposer if you are not wrapping it into @mainactor and concurrency in my Swift6 project. But I can assure it is planned. |
@ekazaev Hi! Yeah I actually had issues where the factory was not letting me create controllers given build was not a main actor. Warnings are gone on my side |
I looked at this, Id probably go slightly different route and put main actor to the entire entity, there is no reason to mark individual calls as MainActor, route-composer deals with UIKit exclusively - so there is no way for it to work off the main thread. |
Please check 2.11.0 version |
🙈🫣😅 |
@ipodishima There is somethign strange. The example app compiled ad passed the test. But the library doesnt compile in the real project. Trying to understand why. Seems just funky compiler issues that it passed |
|
@ipodishima I think Ill roll back. It was too easy and create a branch that you can contribute to. Cant spend more time on it right now unfortunately. |
I’ll take a look on tomorrow. As for main actor on protocol I agree. At first, I didn’t know about everything so I wasn’t sure it would be all main thread ahah. So I pulled a thread. Besides that, thank you for this library, I really like it. Some things are a bit obscure and sometimes complex to use but our navigation improved. |
Hello!
I'm trying to switch my app to Swift 6 and I'm having a lot of errors with Route Composer.
Is there any plan to support Swift 6?
I don't know how deep this would be to be honest.
Thanks
Edit: Given this is a big part of my app, I'm trying to work on it but it's my first time migrating to this concurrency thing so I might not do it properly, and I have a build error on the example project. It's working fine on my app though!
https://github.com/ekazaev/route-composer/compare/master...ipodishima:route-composer:feature/swift6?expand=1
The text was updated successfully, but these errors were encountered: