Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardizing log collection #1

Open
mikkokotila opened this issue May 18, 2019 · 1 comment
Open

standardizing log collection #1

mikkokotila opened this issue May 18, 2019 · 1 comment
Assignees

Comments

@mikkokotila
Copy link
Contributor

@m-anish

Can we get Terry into this thread to discuss the way the logs are compiled now. I think the easiest would be that he shares the scripts that do it, I modify it, and he implements it.

The issue currently is that the logs are parsed in a totally non-standard way, which results in risk of errors when they are parsed to meaningful format. Ideally for any data, but particularly for something as important as QOS data, it's best practice to handle formats in the source.

For example, now we have entries where one row has a timestamp, and then the following rows are entries related with that timestamp. Whereas the standard way is to have the timestamp together with each event. More generally, all the logs should follow a standard "line == event" approach where we always know that if it's a row, it's a self-contained event.

@mikkokotila
Copy link
Contributor Author

For example, now we have:

### Wed Sep 19 18:30:11 2018
[B.A.T.M.A.N. adv 2016.5, MainIF/MAC: wlan0-1/e4:95:6e:43:16:7e (bat0/9a:46:c5:97:29:29 BATMAN_IV)]
   Originator        last-seen (#/255) Nexthop           [outgoingIF]
   e4:95:6e:4b:83:f5    0.910s   (  0) e4:95:6e:40:5e:bd [   wlan0-1]
   e4:95:6e:4b:83:f5    0.910s   (198) e4:95:6e:40:5e:b8 [   wlan0-1]

... which consist of a two records. So it should instead be:

Wed Sep 19 18:30:11 2018   e4:95:6e:4b:83:f5    0.910s   (  0) e4:95:6e:40:5e:bd [   wlan0-1]
Wed Sep 19 18:30:11 2018   e4:95:6e:4b:83:f5    0.910s   (198) e4:95:6e:40:5e:b8 [   wlan0-1]

So small changes, but big difference. The log file or the log folder could contain the header, or then the header could be contained in each record as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants