Ignore NaN and Inf Values in PID controler Inputs #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request introduces checks to handle NaN and Inf values in the ControllerInput struct given in the update function.
If either the ReferenceSignal or ActualSignal contains invalid NaN or Inf values, the update process will safely terminate without affecting the controller's state.
It ensure that invalid inputs do not propagate through the system.
More question about your module
SamplingInterval
externally instead of calculating it as an internal variable?Are you using it with an external time source?