Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save response from failed notification in database #254

Closed
vasile-baluta opened this issue Feb 26, 2019 · 1 comment
Closed

Save response from failed notification in database #254

vasile-baluta opened this issue Feb 26, 2019 · 1 comment
Assignees
Labels
bug Something is wrong and needs fixing.

Comments

@vasile-baluta
Copy link
Contributor

vasile-baluta commented Feb 26, 2019

Description

Today Eiffel Intelligence back-end does not store any information about a failed notification in the database. It is logged to the console, but users who does not have access to this does not see why a notification failed.

When a subscription triggers EI attempts to notify about this using REST POST or MAIL. If either of those fails for some reason, EI currently saves 1) subscription name, 2) time 3) state of the aggregated object when subscription triggered 4) notification meta. This is not enough information for the user if they want to find out WHY something went wrong.

We also need to document these changes, what happens when a subscription fails.

Motivation

No information about what happens when a subscription fails. The user still has to search logs when they notice a notification has not happened.

There is an issue eiffel-community/eiffel-intelligence-frontend#256 in front-end about making any failed notification visible in the GUI for users to readily be able to debug their flows. However, in order to be able to visualize the WHY in the GUI back-end needs to store this information also.

Exemplification

Benefits

Easier to use Eiffel Intelligence and to ensure your subscriptions are working properly. If something goes wrong, the user can understand why this happened (e.g. could be a misspelled URL or MAIL, or REST service down) and attempt to fix this.

Possible Drawbacks

@e-pettersson-ericsson
Copy link
Member

e-pettersson-ericsson commented Jul 9, 2019

We have a section explaining the use of missed notifications described here and what they are. However, currently they are not very useful without the information about what went wrong.

@e-pettersson-ericsson e-pettersson-ericsson added the question Further information is required. label Aug 7, 2019
@e-pettersson-ericsson e-pettersson-ericsson changed the title Answer what happens with failed subscriptions Save response from failed notification in database Sep 12, 2019
@e-pettersson-ericsson e-pettersson-ericsson added bug Something is wrong and needs fixing. and removed question Further information is required. labels Sep 12, 2019
@Christoffer-Cortes Christoffer-Cortes self-assigned this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs fixing.
Projects
None yet
Development

No branches or pull requests

3 participants