Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging support #9

Open
magnusbaeck opened this issue Dec 19, 2019 · 0 comments
Open

Better logging support #9

magnusbaeck opened this issue Dec 19, 2019 · 0 comments

Comments

@magnusbaeck
Copy link
Member

magnusbaeck commented Dec 19, 2019

Description

When the code has something to say it should use the standard logging module instead of today's print statements (used in just a couple of places). When running the web app we can configure the logging via Gunicorn, but when running storage.py standalone we should accept a --logconfig argument (or similar) that loads logging configuration with dictConfig() like gunicorn can do.

Motivation

That's the standard way of logging messages and will allow users to get timestamps, custom output formats, and what-not.

Benefits

I'd expect anyone deploying this to production to want to have proper logs. Externalizing the logging configuration will also make it possible to adjust the level of loggers deeper down in the stack, e.g. pika.

Possible Drawbacks

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant