Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI checks #11

Open
simonge opened this issue Mar 12, 2024 · 5 comments
Open

Add CI checks #11

simonge opened this issue Mar 12, 2024 · 5 comments

Comments

@simonge
Copy link

simonge commented Mar 12, 2024

Currently checks on the output of the afterburner are done manually and on an adhoc sample of events which will not represent the full range of event generators and settings which need afterburning.

I would like to have some checks set up to make sure any changes made do not inadvertently break a current workflow.

@DraTeots
Copy link
Contributor

That is absolutely right idea. The caveat is that there at the last time we run the validation some changes were needed on pythia side. I think Brian needs to be involved to resurrect and finish this part.

@simonge
Copy link
Author

simonge commented Mar 12, 2024

Initially I was hoping to just making sure the output of the afterburner is consistent with the previous output, or changes as expected. Automatically reproducing the validation plots against pythia would probably come second. Although I guess the current version should be compared to pythia in case anything has changed in the meantime.

Trying to do this by myself is going to be very inefficient, the whole CI workflow definitions in yml is currently rather opaque to me and the versions in other repositories, necessarily, look very complicated.

@DraTeots
Copy link
Contributor

It might be an off topic, but recently ChatGPT provided me with pretty good starting .yaml file for github actions that was working out of the box.

@simonge
Copy link
Author

simonge commented Mar 12, 2024

Thanks, definitely not off topic. I can't pretend I wasn't trying to get Copilot to start me off but probably asking the wrong things.

@DraTeots
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants