From 95286e90e2a2662dee4d0502a6757fb961ab8396 Mon Sep 17 00:00:00 2001
From: simonge <simon.gardner@glasgow.ac.uk>
Date: Tue, 20 Aug 2024 19:02:58 +0100
Subject: [PATCH] More sonarcloud advised changes

---
 src/algorithms/meta/SubDivideFunctors.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/algorithms/meta/SubDivideFunctors.h b/src/algorithms/meta/SubDivideFunctors.h
index 9febc0614..b3c9a885f 100644
--- a/src/algorithms/meta/SubDivideFunctors.h
+++ b/src/algorithms/meta/SubDivideFunctors.h
@@ -54,7 +54,7 @@ class RangeSplit {
 class GeometrySplit {
 public:
 
-    GeometrySplit(const std::vector<std::vector<long int>>& ids, std::string readout, std::vector<std::string> divisions)
+    GeometrySplit(const std::vector<std::vector<long int>>& ids, const std::string& readout, const std::vector<std::string>& divisions)
     : m_ids(ids), m_readout(readout), m_divisions(divisions){};
 
     template <typename T>
@@ -88,8 +88,8 @@ class GeometrySplit {
     }
 
     const std::vector<std::vector<long int>>& m_ids;
-    std::vector<std::string> m_divisions;
-    std::string m_readout;
+    const std::vector<std::string>& m_divisions;
+    const std::string& m_readout;
 
     mutable std::shared_ptr<std::once_flag> is_init = std::make_shared<std::once_flag>();
     mutable dd4hep::DDSegmentation::BitFieldCoder* m_id_dec;