Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable build script for library builds #467

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

DaniPopes
Copy link
Contributor

The build script is only used for emitting the FULL_VERSION environment variable, which is only used in the binary. Make it a noop if "bin" is not enabled.

@DaniPopes DaniPopes requested a review from a team as a code owner November 10, 2024 15:33
@DaniPopes DaniPopes requested review from ajpal and removed request for a team November 10, 2024 15:33
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #467 will not alter performance

Comparing DaniPopes:optional-build (1bcaef5) with main (ca52ac1)

Summary

✅ 8 untouched benchmarks

@saulshanabrook
Copy link
Member

Is the main advantage of this that library builds don't need chrono?

@DaniPopes
Copy link
Contributor Author

DaniPopes commented Nov 13, 2024

Yeah and that the build script won't do anything. Unfortunately I don't think there is a way to completely disable the build script, but we can make it do the least amount of work possible.

@Alex-Fischman Alex-Fischman merged commit 1d31817 into egraphs-good:main Nov 18, 2024
5 checks passed
@DaniPopes DaniPopes deleted the optional-build branch November 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants