Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll Build fail due to logger #266

Open
nelsontm opened this issue Aug 30, 2024 · 3 comments
Open

Jekyll Build fail due to logger #266

nelsontm opened this issue Aug 30, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@nelsontm
Copy link

@seshrs see bug details and (temporary?) fix in https://github.com/eecs370/project_1_spec/issues/32

Can this be fixed directly from primer spec or do we need to copy the fix to all of our spec repos?
(@hmuench7 if so, add to your to-dos for other projects)

@nelsontm nelsontm added the bug Something isn't working label Aug 30, 2024
@seshrs
Copy link
Member

seshrs commented Aug 30, 2024

Nice find, thanks for investigating and sharing! 🚀

I think this can be fixed for all repos by adding the dependency constraint to Primer Spec’s gemspec. @nelsontm / @hmuench7: Would you like to help put up a PR?

(Alternatively, I can get to it during the weekend.)

@nelsontm
Copy link
Author

With the back-to-school tasks, I won't be able to get to it for a while. Guessing the same for @hmuench7?

@hmuench7
Copy link

Yes same for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants