Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get version with importlib.metadata #76

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

awdeorio
Copy link
Contributor

@awdeorio awdeorio commented Mar 29, 2024

Modernize how Madoop obtains its own version string for the --version flag implementation.

On some installs, we get an error

$ madoop  --version
Traceback (most recent call last):
  File "/opt/homebrew/bin/madoop", line 5, in <module>
    from madoop.__main__ import main
  File "/opt/homebrew/lib/python3.11/site-packages/madoop/__main__.py", line 12, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

It looks like pkg_resources is deprecated and is replaced by importlib.metadata

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (63a8f6e) to head (ff650bc).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    96.34%   96.32%   -0.02%     
===========================================
  Files            4        4              
  Lines          246      245       -1     
===========================================
- Hits           237      236       -1     
  Misses           9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awdeorio awdeorio merged commit b9356dd into develop Mar 29, 2024
3 checks passed
@awdeorio awdeorio deleted the bugfix-version-flag branch March 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant