Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation fixes 18th June '24 #166

Closed
10 tasks done
edwardchalstrey1 opened this issue Jun 18, 2024 · 1 comment · Fixed by #170
Closed
10 tasks done

Presentation fixes 18th June '24 #166

edwardchalstrey1 opened this issue Jun 18, 2024 · 1 comment · Fixed by #170

Comments

@edwardchalstrey1
Copy link
Owner

edwardchalstrey1 commented Jun 18, 2024

  • If year from and year to are not recorded for absent/present or categorical vars, substitute in the duration years by default
  • Change how the unocded/ no Seshat page for absent/present or categorical vars are handled - Jim's suggestion:
    • In the current variable display you have uncoded as a sort of pink but I too easily begin to think of that as absent (red) without another compelling example at the same time. I propose that you display uncoded in grey like ‘no seshat page’ (but give it a black border to indicate there is a page). Subtle yes but I think less misleading and it tells RAs/experts where missing codes are more easily. The legend should just list ‘Uncoded’; clicking on a grey shape will tell you if you have a seshat page or not.

    • One problem with this could be that having the GADM borders underneath historical polities that both have black borders could look a bit confusing - so give polities a grey border?
    • Solution: Keep the coloured borders for polities, but just make uncoded grey and drop from legend
  • I see the ‘coded unknown’ has a black border which stands out well. Why don’t the present/absent/present_to_absent/absent_to_present have a similar black border rather than their (same) color

    • Answer: when you have GADM selected there are already black borders for the current borders
  • Improve or comment out the 'Switch to' button
    • ‘Switch to’ button confusing and would drop it for the moment

  • The legend clicking is a bit buggy, should we remove it for now and restore it later when we get to Shape display colour, name and clicking issues/ ideas #130 ?
    • I would drop The legend altogether in Polity mode.

    • Answer: I don't think this should be removed as it it works well for looking at a selection of polities of interest, especially where colours are similar
  • Drop the Opacity slider as this doesn't help

    • Answer: I think this should be kept so the user has max controls over the visuals
  • Consider restoring the years/second value in the animation options (the problem before is this won't be very accurate as it slows down when more shapes are displayed)
    • Do this for polity pages too
  • > I think you can eliminate the ‘instructions’ since it is easy enough to discover everything except the double-clicking.
  • Can we lock the zoom so that you can't go further out than one Earth?
  • Make GADM basemap 0.5 white fill instead of blank
    • Can't remember why I said this
  • Make world map fonts/themes up to date with the rest of the Seshat site - moved to Code optimisations and simple feature additions #110
  • Improve year selection on maps #165
  • Add increments for the +/- buttons - moved to Code optimisations and simple feature additions #110
  • Make polity map twice as big
  • Tidy world map side panel including adding the selected year in the same font as on the polity map
@edwardchalstrey1
Copy link
Owner Author

edwardchalstrey1 commented Jun 24, 2024

TODO

@github-project-automation github-project-automation bot moved this from In Progress to Done in Seshat - DEPRECATED Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant