You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.
I'm not sure if this is intended behaviour, but EventBus.fire does not check for listeners of superclass types - so if you create an event class and then subclass it, subscribers of the superclass event won't be notified when firing the subclass event.
I think it would be beneficial for extensibility and reusability to support notifying superclass subscribers; it doesn't seem like an intentional design choice to not do so.
The text was updated successfully, but these errors were encountered:
An alternative to checking the superclasses could be specifying the event type as a reified generic/parameter in EventBus.fire, rather than retrieving the KClass through reflection; this would be easier to implement, though less intuitive than notifying superclass subscribers.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm not sure if this is intended behaviour, but
EventBus.fire
does not check for listeners of superclass types - so if you create an event class and then subclass it, subscribers of the superclass event won't be notified when firing the subclass event.I think it would be beneficial for extensibility and reusability to support notifying superclass subscribers; it doesn't seem like an intentional design choice to not do so.
The text was updated successfully, but these errors were encountered: