From 05ada1101ef5e8ac651c26da883a3ad539cc552f Mon Sep 17 00:00:00 2001 From: Kyle McCormick Date: Tue, 18 Jul 2023 14:41:48 -0400 Subject: [PATCH] build: remove unused libsass dependency (#1987) (Bumps version: 5.1.1 -> 5.2.0) We remove the libsass Python requirement as it doesn't seem to be used any more. (I was able to compile ORA's assets by running `make static`; no Python dependencies needed.) Removing libsass from ORA's requirements will allow us to move it out of edx-platform's base requirements and into a new static-asset-compilation-specific requirements stage. Libsass [1] is a deprecated Sass compilation library written in C, and installing it into edx-platform adds a whole minute to the build because there are no pre-compiled binaries available for the version we install. 1. https://sass-lang.com/libsass/ Closes: https://github.com/openedx/edx-ora2/issues/1986 --- Makefile | 2 +- openassessment/__init__.py | 2 +- package.json | 2 +- requirements/base.in | 1 - requirements/base.txt | 2 -- requirements/quality.txt | 2 -- requirements/test-acceptance.txt | 2 -- requirements/test.txt | 2 -- 8 files changed, 3 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 9ee30ee406..90e9bc0604 100644 --- a/Makefile +++ b/Makefile @@ -26,7 +26,7 @@ clean: ## remove generated byte code, coverage reports, and build artifacts ################## install-python: ## Install python dependencies - pip install -r requirements/base.txt --only-binary=lxml,libsass + pip install -r requirements/base.txt --only-binary=lxml install-js: ## install JavaScript dependencies npm install diff --git a/openassessment/__init__.py b/openassessment/__init__.py index a93603df93..5345892458 100644 --- a/openassessment/__init__.py +++ b/openassessment/__init__.py @@ -1,4 +1,4 @@ """ Initialization Information for Open Assessment Module """ -__version__ = '5.1.1' +__version__ = '5.2.0' diff --git a/package.json b/package.json index 866d5df0ba..77ec91fdde 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "edx-ora2", - "version": "5.1.1", + "version": "5.2.0", "repository": "https://github.com/openedx/edx-ora2.git", "dependencies": { "@edx/frontend-build": "^6.1.1", diff --git a/requirements/base.in b/requirements/base.in index c7973edeaa..972338b182 100644 --- a/requirements/base.in +++ b/requirements/base.in @@ -22,7 +22,6 @@ defusedxml django-model-utils jsonfield lazy -libsass loremipsum lxml path.py diff --git a/requirements/base.txt b/requirements/base.txt index 1bcf403356..a382499cfe 100644 --- a/requirements/base.txt +++ b/requirements/base.txt @@ -94,8 +94,6 @@ jsonfield==3.1.0 # edx-submissions lazy==1.5 # via -r requirements/base.in -libsass==0.22.0 - # via -r requirements/base.in loremipsum==1.0.5 # via # -c requirements/constraints.txt diff --git a/requirements/quality.txt b/requirements/quality.txt index 080b1a6b85..3cdab61178 100644 --- a/requirements/quality.txt +++ b/requirements/quality.txt @@ -262,8 +262,6 @@ lazy==1.5 # via -r requirements/test.txt lazy-object-proxy==1.9.0 # via astroid -libsass==0.22.0 - # via -r requirements/test.txt loremipsum==1.0.5 # via # -c requirements/constraints.txt diff --git a/requirements/test-acceptance.txt b/requirements/test-acceptance.txt index d22ea1a24d..69bbb06d8d 100644 --- a/requirements/test-acceptance.txt +++ b/requirements/test-acceptance.txt @@ -251,8 +251,6 @@ lazy==1.5 # via # -r requirements/test.txt # bok-choy -libsass==0.22.0 - # via -r requirements/test.txt loremipsum==1.0.5 # via # -c requirements/constraints.txt diff --git a/requirements/test.txt b/requirements/test.txt index 85c41d5a48..85d38e3e7a 100644 --- a/requirements/test.txt +++ b/requirements/test.txt @@ -198,8 +198,6 @@ junit-xml==1.9 # via cfn-lint lazy==1.5 # via -r requirements/base.txt -libsass==0.22.0 - # via -r requirements/base.txt loremipsum==1.0.5 # via # -c requirements/constraints.txt