From 008d615e15f9d7d92cb3aade1f42ce106d39cadf Mon Sep 17 00:00:00 2001
From: Edmund Hung <edmund@cloudflare.com>
Date: Sat, 14 Sep 2024 15:55:50 +0100
Subject: [PATCH 1/2] fix(conform-react): stop updating value of input buttons

---
 packages/conform-react/hooks.ts         | 9 +++++++--
 playground/app/routes/form-control.tsx  | 6 ++++++
 tests/integrations/form-control.spec.ts | 4 ++++
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/packages/conform-react/hooks.ts b/packages/conform-react/hooks.ts
index dcee2064..11c0f3c4 100644
--- a/packages/conform-react/hooks.ts
+++ b/packages/conform-react/hooks.ts
@@ -135,8 +135,13 @@ export function useForm<
 				const next = stateSnapshot.key[element.name];
 				const defaultValue = stateSnapshot.initialValue[element.name];
 
-				if (prev === 'managed') {
-					// Skip fields managed by useInputControl()
+				if (
+					prev === 'managed' ||
+					element.type === 'submit' ||
+					element.type === 'reset' ||
+					element.type === 'button'
+				) {
+					// Skip buttons and fields managed by useInputControl()
 					continue;
 				}
 
diff --git a/playground/app/routes/form-control.tsx b/playground/app/routes/form-control.tsx
index dad98b68..81fbfa85 100644
--- a/playground/app/routes/form-control.tsx
+++ b/playground/app/routes/form-control.tsx
@@ -128,6 +128,12 @@ export default function FormControl() {
 						>
 							Reset form
 						</button>
+						<input
+							type="submit"
+							className="rounded-md border p-2 hover:border-black"
+							name="example"
+							value="Submit"
+						/>
 					</div>
 				</Playground>
 			</Form>
diff --git a/tests/integrations/form-control.spec.ts b/tests/integrations/form-control.spec.ts
index 039b3ea5..54c00cc8 100644
--- a/tests/integrations/form-control.spec.ts
+++ b/tests/integrations/form-control.spec.ts
@@ -14,6 +14,7 @@ function getFieldset(form: Locator) {
 		clearMessage: form.locator('button:text("Clear message")'),
 		resetMessage: form.locator('button:text("Reset message")'),
 		resetForm: form.locator('button:text("Reset form")'),
+		inputButton: form.locator('input[type="submit"]'),
 	};
 }
 
@@ -21,6 +22,9 @@ async function runValidationScenario(page: Page) {
 	const playground = getPlayground(page);
 	const fieldset = getFieldset(playground.container);
 
+	// Conform should not overwrite the value of any input buttons
+	await expect(fieldset.inputButton).toHaveValue('Submit');
+
 	await expect(playground.error).toHaveText(['', '', '']);
 
 	await fieldset.validateMessage.click();

From e9aeca5e2b2dba767d21f2b0582e5c9d2fa92b53 Mon Sep 17 00:00:00 2001
From: Edmund Hung <edmund@cloudflare.com>
Date: Sat, 14 Sep 2024 15:56:39 +0100
Subject: [PATCH 2/2] add changeset

---
 .changeset/afraid-owls-repair.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/afraid-owls-repair.md

diff --git a/.changeset/afraid-owls-repair.md b/.changeset/afraid-owls-repair.md
new file mode 100644
index 00000000..35dc7a60
--- /dev/null
+++ b/.changeset/afraid-owls-repair.md
@@ -0,0 +1,5 @@
+---
+'@conform-to/react': patch
+---
+
+fix(conform-react): stop updating value of input buttons