Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass MessageClient to config provider #468

Open
jinlinGuan opened this issue Mar 9, 2023 · 4 comments
Open

Pass MessageClient to config provider #468

jinlinGuan opened this issue Mar 9, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jinlinGuan
Copy link
Contributor

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for all

Description [REQUIRED]

We implemented a new config provider which uses the message bus to watch for configuration changes.
It would be better if the go-mod-bootstrap can find a way to pass the Message Client to the config provider, because the config provider doesn't have the capability to retrieve credentials.
It also can allow the additional metrics collected from the config provider, such as configuration change times.

Describe the solution you'd like

TBD
@jinlinGuan jinlinGuan added the enhancement New feature or request label Mar 9, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Mar 9, 2023
@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Technical WG Mar 9, 2023
@cloudxxx8
Copy link
Member

@lenny-intel could you please provide the suggestion about how to implement it? is it possible to pass a messageClient channel to the configuration provider?

@lenny-goodell
Copy link
Member

@cloudxxx8 , my understanding is your Config Provider Client implementation is subscribing to the changes via the MessageBus, correct?
I see a major issue with this in that the MessageBus config is stored in the Configuration Provider. So the your Client has to be created in order to get the MessageBus configuration. This gets even more complicated in secure mode with connecting to the Secure MessageBus.

Please add this to the agenda for this weeks Core WG.

@cloudxxx8
Copy link
Member

we can try to pass a subscription function as callback to WaitForChange???

@cloudxxx8 cloudxxx8 moved this from Release Backlog to Icebox in Technical WG Apr 24, 2023
@cloudxxx8
Copy link
Member

move to icebox, because the effort of implementing this feature is large

@jumpingliu jumpingliu moved this from Icebox to Release Backlog in Technical WG Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Release Backlog
Development

No branches or pull requests

3 participants