Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata.kata-image: don't include tdnf/history.db #834

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

katexochen
Copy link
Member

This fixes a reproducibility issue, as the db contained timestamps.

This fixes a reproducibility issue, as the db contained timestamps.

Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen requested review from Freax13 and msanft August 27, 2024 11:35
@katexochen katexochen added the no changelog PRs not listed in the release notes label Aug 27, 2024
@Freax13
Copy link
Contributor

Freax13 commented Aug 27, 2024

I think I still have reproducibility issues.

@Freax13
Copy link
Contributor

Freax13 commented Aug 27, 2024

I think I still have reproducibility issues.

The output of /nix/store/k2iz8avb5d0scq0dqhg4whgc7vd51yki-kata-image-3.7.0.drv in cachix doesn't match the build output on my machine.

@katexochen
Copy link
Member Author

The output of /nix/store/k2iz8avb5d0scq0dqhg4whgc7vd51yki-kata-image-3.7.0.drv in cachix doesn't match the build output on my machine.

We have p11-glue/p11-kit#656 to fix this, but it will take some time to trickle down. Should we go ahead and merge this PR @Freax13 ?

@katexochen katexochen merged commit 44fef5c into main Aug 29, 2024
11 of 12 checks passed
@katexochen katexochen deleted the p/kata-image-repro branch August 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants