Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling MetaMask chain switching #141

Open
annybs opened this issue Jan 19, 2022 · 1 comment
Open

Handling MetaMask chain switching #141

annybs opened this issue Jan 19, 2022 · 1 comment
Labels
bug security

Comments

@annybs
Copy link
Member

annybs commented Jan 19, 2022

The MetaMask synchronisation has been improved, but there isn't any validation of the network currently selected.

Officially, we support pairs of XE mainnet <-> Ethereum Mainnet and XE testnet <-> Rinkeby Test Network but this isn't meaningfully enforced or validated.

This means that it is possible to lose EDGE by depositing from the wrong network.

We should tighten this up, and perhaps forcibly disconnect/reset the deposit modal if an invalid network is selected.
@annybs annybs changed the title Handling MetaMask account/chain switching Handling MetaMask chain switching Jan 19, 2022
@annybs
Copy link
Member Author

annybs commented Jan 21, 2022

Might be a good idea to complete #143 before tackling this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annybs