Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapWithKeys().all() returns type array, when it's actually an object #304

Closed
BrennerSpear opened this issue Jun 23, 2022 · 2 comments
Closed

mapWithKeys().all() returns type array, when it's actually an object #304

BrennerSpear opened this issue Jun 23, 2022 · 2 comments

Comments

@BrennerSpear
Copy link 

const contractsCollection = collect(contracts)
const keys = contractsCollection.mapWithKeys((contract) => [contract.address, contract.abi])
const contractToAbiMap = keys.all()

keys.all() returns type unknown[] when it should be returning an object type
@ecrmnn
Copy link
Owner

ecrmnn commented Jun 25, 2022

Thanks for reporting.
I don’t personally use TypeScript, but would appreciate a pull request 😊

@ecrmnn ecrmnn closed this as completed Jun 25, 2022
@BrennerSpear
Copy link
Author

Just put up #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecrmnn @BrennerSpear