Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date processing should utilise lubridate::parse_date_time() #17

Open
ChristianSpence opened this issue Dec 2, 2022 · 1 comment
Open

Date processing should utilise lubridate::parse_date_time() #17

ChristianSpence opened this issue Dec 2, 2022 · 1 comment

Comments

@ChristianSpence
Copy link
Member

Few things:

  • parsing dates should be handled as a separate function from building a dates data.frame, or at least the dates data.frame should be triggered by an argument.
  • managing different formats would be better handled with lubridate::parse_date_time() to sit on the C library for speed
@ChristianSpence
Copy link
Member Author

Now being worked on in /workbench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristianSpence