Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submissions/validation #12

Open
3 tasks
emmamendelsohn opened this issue Oct 27, 2023 · 4 comments
Open
3 tasks

Submissions/validation #12

emmamendelsohn opened this issue Oct 27, 2023 · 4 comments
Assignees

Comments

@emmamendelsohn
Copy link
Collaborator

  • Check file format, bounding box, and resolution
  • minioclient package to transfer from submission to forecast directory
  • Wrap in a GutHub action triggered by a new submission

Is this what you had in mind @cboettig? Anything else?

@emmamendelsohn emmamendelsohn self-assigned this Oct 27, 2023
@emmamendelsohn
Copy link
Collaborator Author

examples of GH actions and submit script

https://github.com/eco4cast/tern4cast/blob/main/.github/workflows/submissions.yaml
https://github.com/eco4cast/tern4cast/blob/main/R/submit.R

@cboettig
Copy link
Collaborator

yup right on!

@emmamendelsohn
Copy link
Collaborator Author

Couple very initial commits here: https://github.com/eco4cast/modis-lai-forecast/tree/submission-workflow

First I modified spat4cast_submit() to add some validation steps. It's a work in progress as I have a few questions:
a) I believe we discussed in the last call that we are enforcing bounding boxes and resolution? In that case, we probably need to modify ingest_planetary_data() to enforce these arguments on a per-site basis. Then the submission checks would be to confirm that the user did not modify any metadata.
b) To perform these checks, I assume we'd need a template. Could we do this with the targets file?
c) Are we only allowing .tif files?
d) How should each submission be tracked if they are all being added as ensembles to the same directory?

I also made a very simple processes_submissions.R file to move the submissions from the submissions directory to the forecasts directory. I don't have EFI credentials so I wasn't able to check if it worked. Anything else we would need to include here? The examples from tern4cast have a lot of user-friendly messages so we can definitely add that.

@cboettig
Copy link
Collaborator

This looks great, can you open a PR and I'll do a quick code review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants