Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme #465

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Readme #465

wants to merge 39 commits into from

Commits on Jan 18, 2019

  1. Update the .classpath file to Java 6

    The POM specifies we are building with Java 6. The classpath
    file should have been the same.
    
    Change-Id: I4525f5b5eab498545ec6b76a479ef5ace62c558f
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5056374 View commit details
    Browse the repository at this point in the history
  2. Remove the text relocation from the build

    The x86 binaries were failing at runtime on Android because of
    text relocation that existed in the shared object. The text
    relocation was a result of the openssl library. This libary
    is not needed for J2V8 so it was removed.
    
    This change-set also updates the NDK to version 14 and updates
    the version of CMake that is used during the build. With
    this change-set applied, x86 and ARM builds should now work.
    
    The version was set to 5.1.0-SNAPSHOT, as we had lots of failed
    builds during 5.0.
    
    Change-Id: I1bef1e0226ddf2e209b48d3f6467bb287acc421f
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    2fd738b View commit details
    Browse the repository at this point in the history
  3. Remove unused build scripts

    With the new CMake build system, the old hand crafted bash scripts
    are no longer needed. This removes he old build tools and docker
    files that are no longer needed.
    
    Change-Id: I6761b5176dfc018c5566644f5a7e789d5edbb7ae
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    bc2aa66 View commit details
    Browse the repository at this point in the history
  4. Create a gitlab ci build for J2V8

    Add a gitlab-ci yaml file so J2V8 can be built on GitLab.
    The gitlabci uses a base docker-dind image, and adds the
    required dependencies. It also sets the commit hash
    in the V8 method that returns the SCM ID. This is useful
    when debugging.
    
    In addition to the new build, this fixes a typo in the name
    of the emulator. Since we updated to a newer NDK build, the emulator
    was suffixed with '64'.
    
    Change-Id: I60b420d16ca26f06a4046b9793e31c47de5220cd
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a3fabba View commit details
    Browse the repository at this point in the history
  5. Set the cross-compiling flag on Node builds

    In preparation of 64-bit builds, the cross-compiling flag is being
    set on the Node.js build. When built on 64-bit platforms (for 64 bit
    Android) this flag must be set to avoid mkpeephole build errors.
    
    Change-Id: I7fe21a87443499bbac9e6b7002abebf320f1ca5e
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b67ce79 View commit details
    Browse the repository at this point in the history
  6. Support 64-bit Android builds

    Adds support for both x86_64 and arm64 builds for J2V8. This sets
    the API version to 23, as version 17 doesn't support 64-bit builds.
    
    This change-set also updates the gitlab-ci build to produce all
    four platforms in a single aar file.
    
    Change-Id: Ie5abc5593a0acc252a1a02f2372af23fae499688
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    1aadfc1 View commit details
    Browse the repository at this point in the history
  7. Use API Level 21 to build

    According to [1], API level 21 introduced 64-bit builds. In the
    interest of keeping the API level as low as possible, we
    are moving to level 21.
    
    [1] https://developer.android.com/ndk/guides/standalone_toolchain
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5ae835c View commit details
    Browse the repository at this point in the history
  8. Fix download links that currently gives 404 to use http://archive.apa…

    …che.org instead where the binaries will have a permanent home.
    Fredrik Sundberg authored and irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    82e0141 View commit details
    Browse the repository at this point in the history
  9. Enable emulator tests for ARM

    The ARM emulator tests were broken for two reasons.
    1. We were accidentally including somme i18l in our
    builds, but not the required libs.
    2. We were not using the right emulator
    
    This change-set fixes both of these. It disables i18l
    in the V8 build, and updates the emulator to android-21
    to match the build.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    85ee122 View commit details
    Browse the repository at this point in the history
  10. No longer pipe ARM build output to a file

    To help see which tests are failing, we no longer pipe the arm build
    output to a file. Instead, we just pipe the Node.js build output
    to a file as we don't really need to see this.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f488305 View commit details
    Browse the repository at this point in the history
  11. Use the quite flag when the build unzips the android platform

    We are producing too much log information and our logs are being
    truncated. Use the quite flag during unzip.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    4d56e03 View commit details
    Browse the repository at this point in the history
  12. Reduce build log even more

    Pipe the docker build output to a file
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5a375e5 View commit details
    Browse the repository at this point in the history
  13. Fail the build if tests are failing

    If the build output contains the words BUILD FAILED then
    we fail the build on gitlab. In the past it was passing.
    Because the build runs in a contained bash env, running on
    supervisord, in a container, it was not possiible to check
    the status code of gradle. Instead we check the logs.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5a1c947 View commit details
    Browse the repository at this point in the history
  14. No longer allocates empty ByteBuffers in native code

    In Android API-21, allocating empty ByteBuffers in native
    code using NULL for the data was leading to seg faults.
    Instead, we pass NULL back to Java and let Java use the
    `ByteBuffer.allocateDirect(0)` API.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f35bd2a View commit details
    Browse the repository at this point in the history
  15. Skip OS Specific tests when running on the emulator

    Many of the platform detector tests fail when running
    on the emulator. This is because the test attempts to
    set the OS property to something else which is not allowed.
    Instead, we skip these tests as it doesn't make sense
    to try and assume that the android emulator is
    Windows, Linux or Mac.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    35ef28c View commit details
    Browse the repository at this point in the history
  16. Ignore some tests that are failing on the emulator

    A few tests are still failing on the emulator. In the interest
    of trying to get a green build so we can debug these properly, we
    have @ignored these.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a6065a6 View commit details
    Browse the repository at this point in the history
  17. Enable builds for all 4 platforms

    Now that builds are working again, enable the full build
    for all 4 platform.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    45a8c68 View commit details
    Browse the repository at this point in the history
  18. Pipe all results of the build command to a file

    Instead of piping different parts of the build command to different
    files, we pipe the entire build command to a single file. We rediect
    standard err to standard out, so everthing ends up in one place.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3d2a65c View commit details
    Browse the repository at this point in the history
  19. Auto deploy master to maven snapshot on each commit

    On each commit to master, auto deploy to maven snapshot repository.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f09d023 View commit details
    Browse the repository at this point in the history
  20. Fix the redirect of standard err to standard out

    The syntax for standard err redirect was incorrect. This fixes
    that.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    cf42b73 View commit details
    Browse the repository at this point in the history
  21. Auto deploy artifacts to maven central

    Adds `bash` and fixes an exit error we had with our .gitlab-ci file.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    67b097e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8123956 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    30e1700 View commit details
    Browse the repository at this point in the history
  24. Install bash during the deploy stage

    Bash is needed to run gradle for the artifact deployment. This
    adds bash to that stage.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    2de8cc7 View commit details
    Browse the repository at this point in the history
  25. Ignore testNestedExecutorExecution

    The testNestedExecutorExecution is failing on occasion. It's not clear if
    this is new. We have filed issue#443 to look at this.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    90e4000 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    fca7238 View commit details
    Browse the repository at this point in the history
  27. Add a deploy stage to the build

    Add a gradle deploy stage that uses env variables for deploy
    credentials.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    c763bdf View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    6065ed0 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    45e3d8d View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    6697c51 View commit details
    Browse the repository at this point in the history
  31. Will not perform a release until all builds are finished

    Builing arm "ALL" was performing all the build steps for arm,
    including the release to Maven Central. We don't the release
    until all 4 platforms are built.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    4998bf8 View commit details
    Browse the repository at this point in the history
  32. Find the right container engine when running buids on MacOS

    When running builds on MacOS, the docker identifier is "darwin/amd64"
    not "linux". This change-set checks if we are running on MacOS
    (Darwin) and sets the required docker platform to `darwin/amd64".
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f418375 View commit details
    Browse the repository at this point in the history
  33. Set the version to 4.8.3 on the 4.8 maintenance branch

    On the 4.8-maintenance set the version number to 4.8.3-SNAPSHOT.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b3b5ab7 View commit details
    Browse the repository at this point in the history
  34. Uses volatile to fix the executor tests

    Some of the executor tests were failing on the emulator. It's
    because the volatile keyword was not being used in the test
    results, and the incorrect results were being cached. This fixes
    those issues.
    irbull committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    974063d View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    f108a42 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    0f237c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. Add a script to install the android dependencies and their licenses

    The builds were failing because of missing licenses. Hopefully
    this fixes that problem.
    irbull committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    102e245 View commit details
    Browse the repository at this point in the history
  2. Wait 2 seconds in the executor tests

    The executor tests requires some time for the second thread to run.
    We now wait 2 seconds in each one of these tests.
    irbull committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    3f3644a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Fix build status in README of 4.8-maintanance branch

    The build status is fetched from Travis-CI.
    It only indicates the Linux build status for 4.8.
    Elmi Ahmadov committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    e764532 View commit details
    Browse the repository at this point in the history