Topdown node sizes #1097
Merged
Topdown node sizes #1097
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behaviour is now consistent with what the melk file says. This is fine for 0.9.2 because it is actually a fix for #1089, where this was wrongly introduced |
soerendomroes
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties TOPDOWN_HIERARCHICAL_NODE_WIDTH and TOPDOWN_HIERARCHICAL_ASPECT_RATIO should always apply to the node they are set on rather than to their children. Prior to this change, in the NULL approximator case this was handled differently and thus led to inconsistent and confusing behaviour.