fixes padding issue of box algorithm #1087
Draft
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu241636
force-pushed
the
box
branch
3 times, most recently
from
2c57e12 to
f312f74
Compare
More changes to box algorithm
Eddykasp
reviewed
Nov 19, 2024
| // add top and bottom padding to total area | ||
| totalArea += Math.sqrt(totalArea) * (padding.getBottom() + padding.getTop()); | ||
| // add left and right padding | ||
| totalArea += Math.sqrt(totalArea) * (padding.getRight()); |
There was a problem hiding this comment.
left padding is missing here. Does adding the padding here help with the underlying issue? I.e. is this something we want finished and merged or does it not really help?
There was a problem hiding this comment.
Taking the padding into account does not fully solve the issue since the desired aspect ratio is a ratio, which cannot be influenced concrete values (the padding). Hence, it helps make it a little better but does not fully solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ticket #866 by taking padding into account when calculating total area.