Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonImporter does not clear existing bend points #1001

Open
spoenemann opened this issue Feb 21, 2024 · 2 comments · May be fixed by #1104
Open

JsonImporter does not clear existing bend points #1001

spoenemann opened this issue Feb 21, 2024 · 2 comments · May be fixed by #1104
Assignees
@Eddykasp
Labels
bug Erroneous behaviour.
Milestone
Release 0.9.2

Comments

@spoenemann
Copy link
Member

Looking more closely at issue eclipse-sprotty/sprotty#427 reported for Sprotty, it seems that it's actually elkjs that's failing to delete the old bend points. The responsible class is JsonImporter.

Just looking at the code, my assumption is that this method in particular should delete old bend points from the JsonObject in case none are provided by the layout algorithm:

elk/plugins/org.eclipse.elk.graph.json/src/org/eclipse/elk/graph/json/JsonImporter.xtend

Line 562 in c6f44e8

if (!edge.sections.nullOrEmpty) {

Can anyone confirm this?
@spoenemann spoenemann mentioned this issue Feb 21, 2024
Closed
@soerendomroes
Copy link
Contributor

We might have time to investigate this in March.
@Eddykasp can we test this with the elk-cli?

@Eddykasp
Copy link
Contributor

I reproduced the issue:
Unlayouted graph: graph-pre-layout.json produces:
graph-pre-layout

If I then change the height of n1 to 70 as in this file
graph-1-layout.json and then run elk again I get the following drawing
graph-1-layout
and this output
final-layout.json.

On elk-live this works correctly since each layout is fresh.

@Eddykasp Eddykasp added the bug Erroneous behaviour. label Feb 22, 2024
@spoenemann spoenemann mentioned this issue Feb 22, 2024
Closed
@spoenemann spoenemann mentioned this issue Mar 25, 2024
Closed
@soerendomroes soerendomroes added this to the Release 0.9.2 milestone Sep 6, 2024
@soerendomroes soerendomroes mentioned this issue Sep 6, 2024
Closed
soerendomroes added a commit to soerendomroes/elk that referenced this issue Dec 13, 2024
@soerendomroes
Delete old json edge sections.
7f1a973 
Fixes eclipse#1001
@soerendomroes soerendomroes mentioned this issue Dec 13, 2024
Closed
@Eddykasp Eddykasp linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eddykasp Eddykasp

Labels
bug Erroneous behaviour.
Projects
None yet
Milestone
Release 0.9.2
3 participants
@spoenemann @soerendomroes @Eddykasp