Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LivelinessSubscriber current tokens option #1115

Open
OlivierHecart opened this issue Jun 11, 2024 · 0 comments
Open

LivelinessSubscriber current tokens option #1115

OlivierHecart opened this issue Jun 11, 2024 · 0 comments
Labels
new feature Something new is needed

Comments

@OlivierHecart
Copy link
Contributor

Describe the feature

For different reasons, the LivelinessSubscriber has been implemented with a similar behavior than the classic Subscriber in the sense that it only receives liveliness tokens declared after the subscriber was created.
There are use cases for this behavior but the most common use case is to receive all currently declared tokens as well as future declared tokens. This forces users to use a zenoh-ext QueryingLivelinessSubscriber.

Getting the current tokens is internally feasible. So it should be possible to add a with_current_tokens() (exact name to be defined) function to the LivelinessSubscriber constructor and avoid having to use a QueryingLivelinessSubscriber.

Note: there is a plan to Remove QueryingSubscriber and NBFTSubscriber and replace them with constructor options. This should be made accordingly.

@OlivierHecart OlivierHecart added the new feature Something new is needed label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

No branches or pull requests

1 participant