Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure Hello exposes public fields #1055

Closed
milyin opened this issue May 27, 2024 · 0 comments · Fixed by #1109
Closed

structure Hello exposes public fields #1055

milyin opened this issue May 27, 2024 · 0 comments · Fixed by #1109
Labels
api fix Correct API

Comments

@milyin
Copy link
Contributor

milyin commented May 27, 2024

Describe the release item

It was decided to not expose struct with public fields in zenoh API, using accessors instead.
This should be done for Hello structure: https://github.com/eclipse-zenoh/zenoh/blob/c-coverage/commons/zenoh-protocol/src/scouting/hello.rs#L105
The field versionfor example is internal and should not be exposed

@milyin milyin added release Part of the next release api sync Synchronize API with other bindings labels May 27, 2024
@milyin milyin added api fix Correct API and removed release Part of the next release api sync Synchronize API with other bindings labels May 30, 2024
@milyin milyin linked a pull request Jun 10, 2024 that will close this issue
@milyin milyin moved this to In review in Zenoh 1.0.0 release Jun 10, 2024
@milyin milyin closed this as completed Jun 12, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Zenoh 1.0.0 release Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fix Correct API
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant