Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align z_hello_locators signature with zenoh-c #671

Closed
sashacmc opened this issue Sep 16, 2024 · 0 comments · Fixed by #677
Closed

Align z_hello_locators signature with zenoh-c #671

sashacmc opened this issue Sep 16, 2024 · 0 comments · Fixed by #677
Assignees
Labels
api sync Synchronize API with other bindings release Part of the next release

Comments

@sashacmc
Copy link
Member

Describe the release item

Currently in zenoh-c we have
void z_hello_locators(const struct z_loaned_hello_t *this_, struct z_owned_string_array_t *locators_out);
but in zenoh-pico we have
const z_loaned_string_array_t *z_hello_locators(const z_loaned_hello_t *hello);
Because in zenoh-pico we already have an object but in zenoh-c we should create it.
For API alignment we should rename current zenoh-pico method to zp_hello_locators (to allow make a call without additional overhead) and create z_hello_locators with the same signature as in zenoh-c (to have aligned API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings release Part of the next release
Projects
Status: Done
1 participant