Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose timeout option in z_get_options_t #215

Closed
cguimaraes opened this issue May 16, 2023 · 2 comments · Fixed by #375
Closed

Expose timeout option in z_get_options_t #215

cguimaraes opened this issue May 16, 2023 · 2 comments · Fixed by #375
Assignees
Labels
api sync Synchronize API with other bindings

Comments

@cguimaraes
Copy link
Member

Describe the feature

Describe the feature

The timeout option (from rust: https://docs.rs/zenoh/0.7.0-rc/zenoh/query/struct.GetBuilder.html#method.timeout) should be exposed in zenoh-pico get options z_get_options_t.

@cguimaraes cguimaraes added the enhancement Things could work better label May 16, 2023
@milyin milyin moved this to Backlog in Zenoh 1.0.0 release Jan 26, 2024
@oteffahi
Copy link
Contributor

The absence of a timeout option in zenoh-pico seems to cause a bug where an instance can hang forever if it performs a get and at least one queryable that received it never responds. Furthermore, the zenoh-pico instance hangs forever even if said queryable is exited.

Steps to reproduce (using 0.10.1-rc):

  • Modify any z_queryable example to insert a sleep call between the reception of the get and sending the reponse. In my tests I use zenoh-python/z_queryable.py.
  • Run the z_queryable example.
  • Run the zenoh-pico/z_get example: zenoh-pico/z_get never times-out during the queryable's sleep call.
  • Stop the z_queryable instance: zenoh-pico/z_get hangs forever.

@milyin milyin added api sync Synchronize API with other bindings and removed enhancement Things could work better labels Mar 12, 2024
@sashacmc
Copy link
Member

@milyin please assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants