Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove z_view_slice_t and related methods #643

Closed
sashacmc opened this issue Sep 3, 2024 · 4 comments
Closed

Remove z_view_slice_t and related methods #643

sashacmc opened this issue Sep 3, 2024 · 4 comments
Assignees
@DenisBiryukov91
Labels
release Part of the next release

Comments

@sashacmc
Copy link
Member

sashacmc commented Sep 3, 2024

Describe the release item

They are not used and we have no them in zenoh-pico:

  • z_view_slice_t
  • z_view_slice_empty
  • z_view_slice_from_buf
  • z_view_slice_is_empty
@sashacmc sashacmc added the release Part of the next release label Sep 3, 2024
@milyin
Copy link
Contributor

milyin commented Sep 4, 2024

Can make them unstable also if it makes sense to keep them, like in #646

@sashacmc
Copy link
Member Author

sashacmc commented Sep 4, 2024

Ok, it will be fine for me.

@DenisBiryukov91
Copy link
Contributor

DenisBiryukov91 commented Sep 4, 2024 •
edited
Loading

We will likely need to preserve z_view_slice_t to provide bindings for ZBytes::slices from eclipse-zenoh/zenoh#1354. Since we would need a way to provide access to non-user-owned uint8_t ptr + length which z_view_slice_t is.

@DenisBiryukov91
Copy link
Contributor

No longer relevant, since z_view_slice_t is now required for z_bytes_slice_iterator_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenisBiryukov91 DenisBiryukov91

Labels
release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@milyin @sashacmc @DenisBiryukov91