Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z_try_recv should return z_result with possible errors E_NODATA and E_CLOSED #568

Closed
milyin opened this issue Aug 5, 2024 · 0 comments
Closed
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Aug 5, 2024

Currently z_try_recv functions for channels returns bool which is false when channel is closed. No data situation is handled by testing received data for gravestone state (with z_check)

After discussion with @DenisBiryukov91 and @sashacmc it was decided that no data situation should be another kind of error. This allows to not call z_check on received data.

This removes the only place where z_check is absolutely necessary. After this change we are free to make z_check rework for #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

1 participant