Revert "Bump typescript-language-server from 4.0.0 to 4.2.0 in /org.eclipse.wildwebdeveloper" #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clipse.wildwebdeveloper"
mickaelistria
force-pushed
the
revert-1428-dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper/typescript-language-server-4.2.0
branch
from
f95108d
to
8fa9a3c
Compare
|
/request-license-review |
✔️ All licenses already successfully vetted. Workflow run (with attached summary files): |
|
@vrubezhny This seems to fix the failing tests. Should we apply it? I don't think I'll personally have the opportunity to debug it further, so unless you can dedicate time to make typescript-ls 4.2 or 4.3 work, it's safer to revert to a state that it known to work well. |
akurtakov
deleted the
revert-1428-dependabot/npm_and_yarn/org.eclipse.wildwebdeveloper/typescript-language-server-4.2.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1428
As this cause some new test failures.