Consume lemminx as a bundle from the OSGi runtime #1741
+46
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like build.properties needs some cleanup |
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
1b57f8d
to
7accb86
Compare
Done! |
|
and version needs a bump. |
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
7accb86
to
867a101
Compare
Done! |
Currently lemminx is embedded into WWD what has some disadvantages: - the jar gets bigger - the embedded jar needs to be extracted before it can be used - version bumps are required for lemminx updates - lemminx can't be updated independent from WWD This now adds a require-bundle to the manifest (so we are getting a certain version we are compatible with) and uses the bundle wiring to get hold of the bundle and then transform it into a file path. Signed-off-by: Christoph Läubrich <[email protected]>
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
867a101
to
26753a7
Compare
|
Looks like the test now needs an import-package. |
I fear this is due to the core.runtime bundle required and its insane re-exports of al system packages... |
If you can replace it with Import-Package, it'd be welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lemminx is embedded into WWD what has some disadvantages:
This now adds a require-bundle to the manifest (so we are getting a certain version we are compatible with) and uses the bundle wiring to get hold of the bundle and then transform it into a file path.
As discused here