Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataObject : Generate converter not only for public but also private package method (getter & setter)) #230

Open
aygalinc opened this issue Jan 8, 2019 · 2 comments · May be fixed by #264
Open

DataObject : Generate converter not only for public but also private package method (getter & setter)) #230

aygalinc opened this issue Jan 8, 2019 · 2 comments · May be fixed by #264
Labels
enhancement

Comments

@aygalinc
Copy link

aygalinc commented Jan 8, 2019

Hi,

I notice in the generated JsonObjectConverter that convertion generation is done by using only public getter and setter. if i want a design where my data Object are close as possible to Immutable Object, i want to keep my setter methods private package. Do you think that code generation can use this method ?

Regards
@slinkydeveloper slinkydeveloper linked a pull request Jun 26, 2019 that will close this issue
Open
@adaussy
Copy link

adaussy commented Oct 30, 2019

I fully agree with you.

@adaussy
Copy link

adaussy commented Oct 31, 2019

I rebased your contribution to master in another pull request:

#283

Sorry I am not used to Github pull request mecanism so I did not know how to update this one. I'm more use to Gerrit ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Now DataObject allows set/get package-private & protected eclipse-vertx/vertx-codegen
3 participants
@adaussy @aygalinc @slinkydeveloper