Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how baseline-compare/replace work #4321

Open
laeubi opened this issue Oct 1, 2024 · 0 comments
Open

Rework how baseline-compare/replace work #4321

laeubi opened this issue Oct 1, 2024 · 0 comments
Labels
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Oct 1, 2024

baseline-compare/replace is quite convoluted with p2-meta-data and actually "breaks" maven semantics as we possibly replace an already published artifact with new versions, what might no longer be possible in Maven 4 sooner or later.

Instead we should rework the process to the following pattern:

  1. If version is known and baseline-replace is active, it searches for an existing artifact (excluding qualifier) and set all artifacts of the build to that version.
  2. In this case the "package-mojos" would write the results as usual but not attach then to the project at all and instead write a properties file mentioning them as we already do for p2 artifacts.
  3. baseline-compare can now compare and possibly fail / warn / ignore

That way it is also much more flexible to use these mojos in a stand-alone fashion (e.g. via CLI invocations).

@laeubi laeubi added the Maven 4 label Oct 1, 2024
@laeubi laeubi added this to the 5.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant