Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Knowledge Agents] Release Checks #641

Closed
6 tasks done
TomBuchertTSystems opened this issue Apr 8, 2024 · 21 comments
Closed
6 tasks done

[Knowledge Agents] Release Checks #641

TomBuchertTSystems opened this issue Apr 8, 2024 · 21 comments
Assignees
Labels
foss RM FOSS definition knowledge agent Feature/Bug for Knowledge Agent component or KIT
Milestone

Comments

@TomBuchertTSystems
Copy link

TomBuchertTSystems commented Apr 8, 2024

Release Info

Version to be included in Eclipse Tractus-X release: 1.12.19

Leading product repository: repository link

Compliance Verifications

This issue tracks all checks, that need to be performed for a product release in Eclipse Tractus-X.

  • Interoperability checks performed
  • Data Sovereignty checks performed

General Checks

Note

Note: most criteria for documentation and security are now covered in TRGs

Security Checks

  • Thread Modelling Analysis passed

Test Results

  • E2E Integration Test passed
  • User Journey approved

Helpful Links

@TomBuchertTSystems TomBuchertTSystems added the knowledge agent Feature/Bug for Knowledge Agent component or KIT label Apr 8, 2024
@drcgjung drcgjung added this to the 24.05 milestone Apr 10, 2024
@drcgjung drcgjung added the foss RM FOSS definition label Apr 10, 2024
@TomBuchertTSystems
Copy link
Author

@bosserf : Can you please conform user journey?

@TomBuchertTSystems TomBuchertTSystems moved this from Inbox to Work in progress in Release Planning Apr 29, 2024
@TomBuchertTSystems
Copy link
Author

Requested appointment for data sovereignty review by @vialkoje

@TomBuchertTSystems
Copy link
Author

Requested approval for interoperability by Per-Henrik Addicks

@bosserf
Copy link

bosserf commented Apr 30, 2024

@TomBuchertTSystems and @kelaja : I herewith give my approval/confirmation regarding the User Journey

@ThomasObermeyer
Copy link

@kelaja According to team no interoperability relevant changes for this release, therefore expert approval granted for interoperability

@vialkoje
Copy link

vialkoje commented May 3, 2024

Data sovereignty:
The business applications have to establish the control plane before accessing the knowledge agents as the dataplane implementation. therefore all topics regarding usage of BPN-L, policy definitions, company-rules and so forth have to be done by the application itself before accessing the knowledge agent API. All relevant QG-criteria are therefore not relevant for this implementation as it only acts as a different way of organizing and transferring the data - that uses an access token provided by the DSP-Sovereign data exchange protocol. Expert approval granted

@vialkoje vialkoje removed their assignment May 3, 2024
@almadigabor almadigabor self-assigned this May 15, 2024
@almadigabor
Copy link

Hey, I've created the TRG check issue. I will need a volunteer committer who does the checks alongside with me. Can you please find me someone? Thanks!

@cbrugg
Copy link

cbrugg commented May 17, 2024

INT Tests done. E2E Tests planned to finish today. Data Sov not relevant. Lets discuss in the QG.

@RolaH1t
Copy link
Contributor

RolaH1t commented May 17, 2024

QG review 17-May
Thread modelling in progress / architecture improved, no major changes
TRG checks completely open, based on final version (PR in progress)
Test completion expected 17-May
final version => 1.12.19
no follow-up mtg required

@szymonkowalczykzf
Copy link

Threat Modeling - approved - all previous finding addressed - no major changes to the architecture / new components added.

@cbrugg
Copy link

cbrugg commented May 17, 2024

E2E Tests also successfully done.
Testmanagement approval is hereby given! Thank you for your efforts!

@RolaH1t
Copy link
Contributor

RolaH1t commented May 21, 2024

Hi @almadigabor we trust you are processing the TRG checks on this product.
As this is the only topic missing, I can approved the QG fully once completed.
Thx Roland

@almadigabor
Copy link

Hey @RolaH1t, as we were waiting for the Eclipse IP check issues to be processed this got a bit delayed. Now we managed to merge the last PRs, create the releases and now I can proceed with the checks.

@almadigabor
Copy link

I'm done with the first round of checks. There is one issues open regarding critical security findings in the knowledge-agents repository by CodeQL. eclipse-tractusx/knowledge-agents#128

Once they are addressed, I can approve and close the TRG checks issue.

@almadigabor
Copy link

As the security findings were false positives as they've already been fixed, the last check is also marked. I approve the QG with the following versions:

App version: 1.12.19
Chart version: 1.12.19

@RolaH1t
Copy link
Contributor

RolaH1t commented May 27, 2024

Congrats:
Quality Gate fully approved with all necessary pre-requisites fulfilled!
Thanks for all your efforts,
Roland

@FaGru3n
Copy link
Contributor

FaGru3n commented May 29, 2024

Hi @RolaH1t and @kelaja guess could be closed, many thanks for your work.

@stephanbcbauer
Copy link
Member

Hello @TomBuchertTSystems

Since the feature is a 24.05 feature and the development phase for 24.08 is coming to an end, we need a status on the feature. Can you please update the status?

  • Currently you are assigned (Responsible) → Is this correct? If not, please assign the correct contact person
  • Please check whether the status (backlog, work in progress ...) is set correctly
  • Please comment on the current status of the feature
  • Are all SubTasks (issues from other repositories that deal with the feature) linked? → The easiest way is to mention the feature here in the issue (via the ID) so we can see which teams/repositories are involved.
  • Is there a spillover planned?

If you need any clarification, please get in touch, thank you very much.

Stephan

@bosserf
Copy link

bosserf commented Jul 3, 2024

Hi @TomBuchertTSystems, kannst Du das hier bitte noch kommentieren? Danke!
Rolf

@mabige
Copy link

mabige commented Jul 3, 2024

@bosserf @TomBuchertTSystems just close this QG issue.
The QG was approved by Roland w/o pending issues.

The checklist from @stephanbcbauer is essential for incomplete features, but does not apply in case of approved QGs.
Seems to be a mistake.

@stephanbcbauer
Copy link
Member

Since this is an old issue and was already approved -> Status Done

@github-project-automation github-project-automation bot moved this from Work in progress to Done in Release Planning Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foss RM FOSS definition knowledge agent Feature/Bug for Knowledge Agent component or KIT
Projects
Status: Done
Development

No branches or pull requests