Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable branch protection for our web-page #515

Closed
FaGru3n opened this issue Nov 30, 2023 · 3 comments · Fixed by eclipse-tractusx/.eclipsefdn#43
Closed

Enable branch protection for our web-page #515

FaGru3n opened this issue Nov 30, 2023 · 3 comments · Fixed by eclipse-tractusx/.eclipsefdn#43
Assignees

Comments

@FaGru3n
Copy link
Contributor

FaGru3n commented Nov 30, 2023

I want to highlight the importance of reviews for our community. Since we are the biggest project in the Eclipse foundation and we already discussed the maintenance of overarching repositories like the Docusaurus instance of eclipse-tractusx.github.io previously in the mail discussion, checks are essential to continue with high-quality outcomes.

At this year's EclipseCon, they highly suggested reviewing every pull request by at least two reviewers. Since Tractus-X aligned for at least one reviewer, I wish that we take this decision as the absolute minimum! During the last time, I saw different pull requests directly merged from the same person without any review or pull requests without any information in it (description) or with removed checkboxes of the standard template. Even if the changes are minor, everything should be communicated clearly and checked by at least one person.

Different Examples (no fingerpointing, just to show what I am talking about):
#490
#513
#476
#474
#463

Hope you are going for the same opinion. Otherwise, I am happy to discuss it here.

Thanks, and have a great week
Malte

@almadigabor
Copy link
Contributor

I guess we can close this one, right @FaGru3n?

@mhellmeier
Copy link
Member

Yes, thats already done in the linked PR.

Maybe we could create a new issue for the Codeowner file as discussed here: eclipse-tractusx/.eclipsefdn#43 (comment)

@FaGru3n
Copy link
Contributor Author

FaGru3n commented Jan 8, 2024

Hi @almadigabor jep issue can be closed sorry for missed mentioning part for this issue.

@mhellmeier Jep seems a good idea to reference all information to our codeowners file into a new issue. 😉

#576

@FaGru3n FaGru3n closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants